Skip to content

Testing

Testing #148

Triggered via pull request November 13, 2023 13:40
@tannebergertanneberger
synchronize #38
testing
Status Success
Total duration 1m 8s
Artifacts

check-and-lint.yaml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

24 warnings
Rustfmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
call to `.clone()` on a reference in this situation does nothing: src/package/mod.rs#L124
warning: call to `.clone()` on a reference in this situation does nothing --> src/package/mod.rs:124:33 | 124 | return Some(path.clone().to_path_buf()); | ^^^^^^^^ help: remove this redundant call | = note: the type `std::path::Path` does not implement `Clone`, so calling `clone` on `&std::path::Path` copies the reference, which does not do anything and can be removed
call to `.clone()` on a reference in this situation does nothing: src/backends/npm.rs#L53
warning: call to `.clone()` on a reference in this situation does nothing --> src/backends/npm.rs:53:54 | 53 | let mut path_copy: Vec<OsString> = output_dir | ______________________________________________________^ 54 | | .clone() | |____________________^ help: remove this redundant call | = note: the type `std::path::Path` does not implement `Clone`, so calling `clone` on `&std::path::Path` copies the reference, which does not do anything and can be removed = note: `#[warn(noop_method_call)]` on by default
called `map(..).flatten()` on `Option`: src/package/mod.rs#L293
warning: called `map(..).flatten()` on `Option` --> src/package/mod.rs:293:30 | 293 | ... .map(|x| x.to_str()) | ________________________^ 294 | | ... .flatten() | |________________________________^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|x| x.to_str())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten = note: `#[warn(clippy::map_flatten)]` on by default
the borrowed expression implements the required traits: src/backends/npm.rs#L110
warning: the borrowed expression implements the required traits --> src/backends/npm.rs:110:23 | 110 | .join(&src_postfix) | ^^^^^^^^^^^^ help: change this to: `src_postfix` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
this creates an owned instance just for comparison: src/backends/npm.rs#L50
warning: this creates an owned instance just for comparison --> src/backends/npm.rs:50:44 | 50 | .position(|element| element == OsString::from("src")) | ^^^^^^^^^^^^^^^^^^^^^ help: try: `*"src"` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned = note: `#[warn(clippy::cmp_owned)]` on by default
redundant field names in struct initialization: src/package/mod.rs#L303
warning: redundant field names in struct initialization --> src/package/mod.rs:303:25 | 303 | name: name, | ^^^^^^^^^^ help: replace it with: `name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names = note: `#[warn(clippy::redundant_field_names)]` on by default
Clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Check: src/backends/npm.rs#L53
call to `.clone()` on a reference in this situation does nothing
Check: src/package/mod.rs#L124
call to `.clone()` on a reference in this situation does nothing
Check
`lingo` (bin "lingo") generated 2 warnings (run `cargo fix --bin "lingo"` to apply 2 suggestions)
Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/