-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Improve eKuiper command-line tools maintainability and usability #2816
Comments
I think |
Thanks for the proposal. I am OK with the refactor. But renaming the commands sound like breaking changes. Recommend to do that in the master-v2 branch. |
You may have misunderstood. I'm not proposing to rename the commands, but rather to group them into separate .go files, which would make maintenance easier. And extends the Below is examples: $ kuiper query
kuiper > CREATE STREAM stream_name ( column_name <data_type> [ ,...n ] ) WITH ( property_name = expression [, ...] );
kuiper > CREATE TABLE table_name ( column_name <data_type> [ ,...n ] ) WITH ( property_name = expression [, ...] );
kuiper > DESCRIBE TABLE table_name; And this feature is not higher priority and not must have cuz there already has same commands could work ( |
This proposal must guarantee |
@ngjaying perhaps we need to vote on this proposal? What steps should I take to start working on this? |
Hi @yai-dev , if no breaking change, you can start to work on this if you like. Thanks |
OK, please assign this issue to me and i'm ready to working on it, and refactor will based on branch |
Thanks. Notice that, CLI is temporarily removed in v2 now. You can try to added it back progressively. |
OKay |
What would you like to be added/modified:
We need seperating
kuiper
's sub-commands into different.go
files, each sub-commands has it own.go
file.Command-Line tools arguments naming should be
kebab-case
.KuiperBaseKey
environment should be public to users and documented and it's naming should be upper case and seperate with underscore.Add
version
flag to get version ofkuiper
andkuiperd
.Why is this needed:
Currently, eKuiper's command-line tools, which include
kuiperd
andkuiper
, offer a lots of functions that made developers and users could work on terminal. However, the arguments are not always clear, and the sub-commands ofkuiper
are written in a single.go
file, which complicates maintenance.Above are all the optimizations I can think of. If you have better suggestions, please reply in the issue to join the discussion.
BTW: This proposal is outside the roadmap maybe? and I can try to work on it.
The text was updated successfully, but these errors were encountered: