Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Release v10.1 #91

Open
ciozi137 opened this issue May 25, 2023 · 17 comments
Open

New Release v10.1 #91

ciozi137 opened this issue May 25, 2023 · 17 comments
Assignees
Labels
Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: In Progress This issue is being worked on, and has someone assigned.

Comments

@ciozi137
Copy link
Member

ciozi137 commented May 25, 2023

Now that the Cypher scaling issue is very likely fixed I think it's time for a new release. Are there any outstanding issues that need to be resolved build we release the next version? Having a list of changes since the last version (v10.0 June 3, 2022) would also be helpful.

@ciozi137 ciozi137 added Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: In Progress This issue is being worked on, and has someone assigned. labels May 25, 2023
@Monkeymerlot
Copy link
Contributor

image

@Monkeymerlot
Copy link
Contributor

image

@Monkeymerlot
Copy link
Contributor

There is something funky going on with the VIs that you moved to the Igor API

@ciozi137
Copy link
Member Author

@Monkeymerlot can you try fetching and pulling changes from the repo? I an working in the development branch.

@Monkeymerlot
Copy link
Contributor

@ciozi137 Looks good. I opened the project, and the driver and all relevant VIs that were giving issues. I had to update the Asylum API of course, but once I did that it opened up right away.

@ciozi137
Copy link
Member Author

Release Notes draft:
[10.1.0]

  • Fix scaling issue related to Cypher scanner
  • Updated dependencies Igor-API and Asylum-API
  • IV Curve plugin
  • Dots fix
  • UI updates

@ciozi137
Copy link
Member Author

@Monkeymerlot , Melanie told me today that the software is ready to be built. She said the g drive issue is fixed and also the Inkscape offset issue. How to do you want to proceed? Do you want to build? Me? Final release notes?

@Monkeymerlot
Copy link
Contributor

Monkeymerlot commented Jul 25, 2023

I think it would be best if you build it. I would definitely mention that the way we handle the background image in inkscape has significantly changed. I think that for a lot of the members of the lab, it works like black magic so perhaps we can make a small update paragraph. Something like this: (go ahead and edit this for clarity as even we had issues describing what was going on to eachother, and we both know the program better than probably anyone else currently in the lab)

The way that the background image previously worked in inkscape was that you would link a jpg image in the inkscape document located at "C:/AFM/surfacepic.jpg" into the inkscape file. The user then would manually set this size to the size of the AFM scan in nanometers, eg a 25.6 um scan size would be 25600 x 26500. The offsets are zero in both x and y. When the user would change the background image in the lithography software (ie change the ibw file), the program would overwrite the file located at C:/AFM/surfacepic.jpg. This would then be reflected by a somewhat magical update in the inkscape software. In the new program, manually setting the size of the background image is still required, however, the location of this background image has changed. It is now stored next to the inkscape file, and the name is now "inkscapefilename_surfacepic.jpg". This allows the path in the inkscape file to always be "./inkscapefilename_surfacepic.jpg", which rids us of the issues that were cropping up with longer relative paths and relocating inkscape files into google drive causing background image links to be broken.

The program should be able to update older files as well, updating them to fit the new workflow automatically.

@Monkeymerlot
Copy link
Contributor

Also maybe we can put tip strips on the path locations for the google drive autoupdate file path controls so people are aware of what they do in the next minor release.

@Monkeymerlot
Copy link
Contributor

Also make sure that you merge the svg-background branch into develop and then into main. I just added a small fix for the autosave render, which is to update the control after it reads from the ini file...

@ciozi137
Copy link
Member Author

@Monkeymerlot thanks. I will merge and see about some tip strips before i build in the next day or so

@Monkeymerlot
Copy link
Contributor

I just realized I should have put that in that small commit as well. Give me one second to push the tip strip to the repository...

@ciozi137
Copy link
Member Author

Take your time. I won't get to this until tomorrow

@Monkeymerlot
Copy link
Contributor

Pushed.

@ciozi137
Copy link
Member Author

@ciozi137
Copy link
Member Author

@Monkeymerlot there are still issues with this release - something offset. Can we meet sometime to discuss and/or track down the problem?

@ciozi137
Copy link
Member Author

ciozi137 commented Sep 6, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: In Progress This issue is being worked on, and has someone assigned.
Projects
None yet
Development

No branches or pull requests

2 participants