Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syslog_post not working correctly? #5

Open
gregsadetsky opened this issue Apr 11, 2024 · 0 comments
Open

syslog_post not working correctly? #5

gregsadetsky opened this issue Apr 11, 2024 · 0 comments

Comments

@gregsadetsky
Copy link
Member

when using the python cli, both calls to disco syslog:add and syslog:remove fail

the call to syslog:remove fails because of a problem in the CLI - the cli function assumes it will get host but it actually gets disco. but that's a separate problem

the bigger issue is here:

def syslog_post(

it looks like syslog_post isn't getting the action parameter correctly?

when calling disco syslog:add --disco 5.161.208.12 "syslog+tls://server.com:1234" (I use a real server url when running it locally), I see in the disco logs:

disco.1.g8bdkwi2tfm7zazjnbivvs0ug 2024-04-11T02:55:14Z   File "/disco/app/disco/endpoints/syslog.py", line 38, in syslog_post
disco.1.g8bdkwi2tfm7zazjnbivvs0ug 2024-04-11T02:55:14Z     assert add_remove_syslog.action == "remove"
disco.1.g8bdkwi2tfm7zazjnbivvs0ug 2024-04-11T02:55:14Z AssertionError

which means that the if add_remove_syslog.action == "add": line didn't work..?

@gregsadetsky gregsadetsky changed the title syslog_post not working correctly? syslog_post not working correctly? Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant