Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing get_disco_file_from_str call? #4

Open
gregsadetsky opened this issue Apr 10, 2024 · 0 comments
Open

missing get_disco_file_from_str call? #4

gregsadetsky opened this issue Apr 10, 2024 · 0 comments

Comments

@gregsadetsky
Copy link
Member

in the deploy endpoint, it seems that a call to get_disco_file_from_str is missing:

https://github.com/letsdiscodev/disco-daemon/blob/main/disco/endpoints/deployments.py#L94

when I try to submit a json file (using the python cli), I get an error that makes me think that the file content wasn't processed properly:

g@tr disco (main *%) % disco deploy --disco 5.161.208.12 --project my-flask-site --commit b848426c89002de8d02d81400881e5b8c4f6d979 --file /Users/g/Desktop/disco/example-flask-sqlite-site/disco.json
Error
{"detail":[{"type":"model_attributes_type","loc":["body","discoFile"],"msg":"Input should be a valid dictionary or object to extract fields from","input":"{\n    \"version\": \"1.0\",\n    \"services\": {\n        \"web\": {\n            \"port\": 8080,\n            \"volumes\": [{\n                \"name\": \"sqlite-data\",\n                \"destinationPath\": \"/sqlitedata\"\n            }]\n        }\n    }\n}","url":"https://errors.pydantic.dev/2.6/v/model_attributes_type"}]}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant