From fe06c6b91bdc44508a654c6993f867c03c513d91 Mon Sep 17 00:00:00 2001
From: Greg Johnston <greg.johnston@gmail.com>
Date: Mon, 15 Apr 2024 16:49:02 -0400
Subject: [PATCH] fix: do not submit `<ActionForm>` on `formmethod="dialog"`
 submission (closes #2523)

---
 router/src/components/form.rs | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/router/src/components/form.rs b/router/src/components/form.rs
index f34e629f49..2601b93595 100644
--- a/router/src/components/form.rs
+++ b/router/src/components/form.rs
@@ -488,6 +488,17 @@ where
                 return;
             }
 
+            // <button formmethod="dialog"> should *not* dispatch the action, but should be allowed to
+            // just bubble up and close the <dialog> naturally
+            let is_dialog = ev
+                .submitter()
+                .and_then(|el| el.get_attribute("formmethod"))
+                .as_deref()
+                == Some("dialog");
+            if is_dialog {
+                return;
+            }
+
             ev.prevent_default();
 
             match ServFn::from_event(&ev) {