Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data-registry updater currently opens a PR, consider more automatic commit instead #8

Open
OliviaLynn opened this issue Apr 5, 2024 · 1 comment

Comments

@OliviaLynn
Copy link
Collaborator

Pros of opening a PR:

  • Have a clear history of updates to the registry
  • Have a person checking in, in case somehow the registry is blank or too short or otherwise off
  • Respects good branch protection practices

Pros of a direct commit:

  • Don't have to check in and merge a PR. If someone adds a data file, they know it will show up. Especially helpful for random 3rd party contributors
@raphaelshirley
Copy link
Member

Hmm interesting. Does this mean that if I were to change the files for some reason and make a PR there would be an additional PR to update the registry that was automatically made?

Would it be possible to automatically update the registry anytime a PR was merged such that anytime the files were updated or added to we updated the registry?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants