Slight code re-organization #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current organization of this gem makes it difficult to customize the behavior of this gem because it contains explicit references to fully qualified method: `UnobtrusiveFlash::ControllerMixin.append_flash_to_cookie` (which we had a need to tweak slightly). I reorganized to make this unneeded and also to follow a common module pattern in the ruby community. This change was beneficial to my team and I suspect might be appreciated by others. It allowed us to easily override methods as needed and the code remains easily testable.
jaredhales
commented
Jan 19, 2018
| @@ -37,7 +41,9 @@ def unobtrusive_flash_keys | |||
| [:notice, :alert, :error, :success, :warning] | |||
| end | |||
|
|
|||
| class << self | |||
| module ClassMethods | |||
There was a problem hiding this comment.
I do wonder why these even need to class methods as opposed to making all of these instance methods (testing purposes I suppose?). We could simplify this more by making these instance methods and using the extend self pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current organization of this gem makes it difficult to customize the behavior of this gem because it contains explicit references to fully qualified method:
UnobtrusiveFlash::ControllerMixin.append_flash_to_cookie(which we had a need to tweak slightly).I reorganized to make this unneeded and also to follow a common module pattern in the ruby community. This change was beneficial to my team and I suspect might be appreciated by others. It allowed us to easily override methods as needed and the code remains easily testable.