Bug: false warning for notification settings

[roeniss]

macOS version

14.6.1(23G93)

MeetingBar version

4.10.0

Installation source

Homebrew

Calendars provider

Google Calendar

Bug description

• I allowed notification of MeetingBar.
• It works perfectly.
• The warning is still there: "Your macOS notification settings for MeetingBar are not set to alert. Do so if you want persistent notifications."

Reproduction steps

I found this bug right after installation.

Expected behavior

The warning disappears.

Screenshots/screen recordings

Additional context

I'm struggling with another issue that a fullscreen notification seems not working (I'll report that separately). This may be related to it.

[dosubot]

A similar issue was previously reported and closed: Bug: Notification warning overlaps with notification setting. The solution mentioned was that it was a bug in the SwiftUI view, and it was to be fixed in the next release at that time ^[1].

In the current codebase, the logic for triggering the notification settings warning is in the JoinEventNotificationPicker struct. It uses the checkNotificationSettings() function to determine the status. The warning is displayed if the alert style is not set to alert and notifications are not disabled, or if notifications are disabled ^[2].

If you have already allowed notifications and the warning persists, it might be worth checking if the alert style is correctly set to alert or banner in your macOS notification settings for MeetingBar. If the issue continues, it could be a regression or a new bug that might need further investigation.

To continue talking to Dosu, mention @dosu.

[dosubot]

A similar issue was previously reported and closed: Bug: Notification warning overlaps with notification setting. The solution mentioned was that it was a bug in the SwiftUI view, and it was to be fixed in the next release at that time ^[1].

In the current codebase, the logic for triggering the notification settings warning is in the JoinEventNotificationPicker struct. It uses the checkNotificationSettings() function to determine the status. The warning is displayed if the alert style is not set to alert and notifications are not disabled, or if notifications are disabled ^[2].

If you have already allowed notifications and the warning persists, it might be worth checking if the alert style is correctly set to alert or banner in your macOS notification settings for MeetingBar. If the issue continues, it could be a regression or a new bug that might need further investigation.

To continue talking to Dosu, mention @dosu.