Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Height can not be valid and all tests pass #24

Open
ckelly38 opened this issue May 16, 2023 · 0 comments
Open

Height can not be valid and all tests pass #24

ckelly38 opened this issue May 16, 2023 · 0 comments
Labels
se curriculum Issue for lessons in the Software Engineering program

Comments

@ckelly38
Copy link

Canvas Link

https://learning.flatironschool.com/courses/6956/assignments/239275?module_item_id=562221

Concern

Nothing. No problems submitting or doing the assignment, but a known bug is discovered and is being reported with the project itself. index.js height variable set on line 2. indexTest.js test on line 14 over simplifies the issue and does not account for this bug.

Additional Context

I did not have a problem with the program, but I did want to note that it is possible to pass in a negative height and use it. And have your height is less than 40 inches test to pass. When height is clearly not valid. Have a look.

Suggested Changes

Make a test to check to make sure that height is at least zero. Now, unless the person is dead or did not exist in the first place, then 0 would also not be valid. But would still pass the height is less than 40 inches requirement.

@ckelly38 ckelly38 added the se curriculum Issue for lessons in the Software Engineering program label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
se curriculum Issue for lessons in the Software Engineering program
Projects
None yet
Development

No branches or pull requests

1 participant