Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexing projects that are not the root of the repository #13

Open
kim-em opened this issue Jan 11, 2024 · 2 comments
Open

indexing projects that are not the root of the repository #13

kim-em opened this issue Jan 11, 2024 · 2 comments
Labels
A-index Area: Package index. PRs without this will skip indexing. C-enhancement Category: Issue requires a new feature.

Comments

@kim-em
Copy link

kim-em commented Jan 11, 2024

Cedar is a great example of a project where the Lean project is in a subdirectory of the main git repository, but we really ought to have on Reservoir!

@tydeu tydeu added the C-enhancement Category: Issue requires a new feature. label Jan 11, 2024
@tydeu
Copy link
Member

tydeu commented Jan 11, 2024

Right now, I do not see an feasible way to do this. There are two major problems:

  1. GitHub code search already has a very low limit on search results (and thus using it already is not heavily scalable). Extending the search to any file in a repository would quickly shoot past the limits.
  2. Repositories can easily have multiple lakefiles. Many of these "pacakges" are things we definitely do not want in Reservoir (e.g., examples). It is thus not clear how to perform such a search without picking up a lot of bad results.

@kim-em
Copy link
Author

kim-em commented Jan 11, 2024

User registration!

@tydeu tydeu added the A-index Area: Package index. PRs without this will skip indexing. label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-index Area: Package index. PRs without this will skip indexing. C-enhancement Category: Issue requires a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants