rw duplicates goals

[eric-wieser]

Prerequisites

Please put an X between the brackets as you perform the following steps:

• Check that your issue is not already filed:
  https://github.com/leanprover/lean4/issues
• Reduce the issue to a minimal, self-contained, reproducible test case.
  Avoid dependencies to Mathlib or Batteries.
• Test your test case against the latest nightly release, for example on
  https://live.lean-lang.org/#project=lean-nightly
  (You can also use the settings there to switch to “Lean nightly”)

Description

The rw tactic sometimes duplicates the same MVarId in the list of goals

Context

[Broader context that the issue occurred in. If there was any prior discussion on the Lean Zulip, link it here as well.]

Steps to Reproduce

Run

theorem duplicate_goal : ∃ a : Int, a = 1 := by
  refine ⟨?_, ?_⟩
  rotate_left
  rw [eq_comm]
  -- three goals
  sorry
  -- two goals
  sorry
  -- zero goals

Expected behavior: There should be two goals after the rw

Actual behavior: The goal state after the rw is

case refine_2
⊢ 1 = ?refine_1
case refine_1
⊢ Int
case refine_1
⊢ Int

Versions

4.15.0-rc1

Additional Information

[Additional information, configuration or data that might be necessary to reproduce the issue]

Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.