-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: parity between structure instance notation and where
notation
#6165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
label
Nov 21, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 21, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 21, 2024
leanprover-community-bot
added
the
breaks-mathlib
This is not necessarily a blocker for merging: but there needs to be a plan
label
Nov 21, 2024
Mathlib CI status (docs):
|
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 22, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 22, 2024
kmill
force-pushed
the
struct_inst_field_args
branch
from
November 30, 2024 02:38
44c24ea
to
c641323
Compare
kmill
changed the title
feat: allow fields in structure instance notation to have arguments
feat: parity between structure instance notation and Nov 30, 2024
where
notation
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 30, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 30, 2024
leanprover-community-bot
added
builds-mathlib
CI has verified that Mathlib builds against this PR
and removed
breaks-mathlib
This is not necessarily a blocker for merging: but there needs to be a plan
labels
Nov 30, 2024
kmill
added a commit
to kmill/lean4
that referenced
this pull request
Nov 30, 2024
This PR is preparation for changes to structure instance notation in leanprover#6165. It adds a syntax category that will be used for field syntax.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 30, 2024
This PR is preparation for changes to structure instance notation in #6165. It adds a syntax category that will be used for field syntax.
kmill
force-pushed
the
struct_inst_field_args
branch
from
November 30, 2024 13:04
c641323
to
c87782d
Compare
kmill
added a commit
to kmill/lean4
that referenced
this pull request
Dec 1, 2024
This PR puts code in terms of syntax quotations now that there has been a stage0 update. Fixes a lingering bug in StructInst where some intermediate syntax was malformed, but this had no observable effects outside of some debug messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
builds-mathlib
CI has verified that Mathlib builds against this PR
changelog-language
Language features, tactics, and metaprograms
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies structure instance notation and
where
notation to use the same notation for fields. Structure instance notation now admits binders, type ascriptions, and equations, andwhere
notation admits full structure lvals. Examples of these for structure instance notation:Just like for the structure
where
notation, a fieldf x y z : ty := val
expands tof := fun x y z => (val : ty)
. The type ascription is optional.The PR also is setting things up for future expansion. Pending some discussion, in the future structure/
where
notation could have have embeddedwhere
clauses; rather than{ a := { x := 1, y := z } }
one could write{ a where x := 1; y := z }
.