diff --git a/CHANGELOG.md b/CHANGELOG.md index c80bc42..9750588 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,7 @@ to avoid `set-output-parameters` final step breaking log group expansion - correct typo of in configuration step: "lake check-test failed" -> "lake check-lint failed" - fix log group expansion in failing steps due to `set-output-parameters` step +and removing the end log group command when a step fails ## v1.0.1 - 2024-8-24 diff --git a/scripts/lake_build.sh b/scripts/lake_build.sh index abe363d..dda56dc 100755 --- a/scripts/lake_build.sh +++ b/scripts/lake_build.sh @@ -10,13 +10,13 @@ handle_exit() { exit_status=$? if [ $exit_status -ne 0 ]; then echo "build-status=FAILURE" >>"$GITHUB_OUTPUT" + echo "::error:: lake build failed" else echo "build-status=SUCCESS" >>"$GITHUB_OUTPUT" + # end log group and add a new line to improve readabiltiy + echo "::endgroup::" + echo fi - - # end log group and add a new line to improve readabiltiy - echo "::endgroup::" - echo } trap handle_exit EXIT diff --git a/scripts/lake_lint.sh b/scripts/lake_lint.sh index e8e79d8..c8075f9 100755 --- a/scripts/lake_lint.sh +++ b/scripts/lake_lint.sh @@ -9,11 +9,12 @@ handle_exit() { exit_status=$? if [ $exit_status -ne 0 ]; then echo "lint-status=FAILURE" >>"$GITHUB_OUTPUT" + echo "::error:: lake lint failed" else echo "lint-status=SUCCESS" >>"$GITHUB_OUTPUT" + echo "::endgroup::" + echo fi - echo "::endgroup::" - echo } trap handle_exit EXIT diff --git a/scripts/lake_test.sh b/scripts/lake_test.sh index ccf314f..730ce02 100755 --- a/scripts/lake_test.sh +++ b/scripts/lake_test.sh @@ -9,11 +9,11 @@ handle_exit() { exit_status=$? if [ $exit_status -ne 0 ]; then echo "test-status=FAILURE" >>"$GITHUB_OUTPUT" + echo "::error:: lake test failed" else echo "test-status=SUCCESS" >>"$GITHUB_OUTPUT" + echo "::endgroup::" fi - echo "::endgroup::" - echo } trap handle_exit EXIT