Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit default options in synported files #127

Open
gebner opened this issue Feb 22, 2022 · 3 comments
Open

Emit default options in synported files #127

gebner opened this issue Feb 22, 2022 · 3 comments

Comments

@gebner
Copy link
Member

gebner commented Feb 22, 2022

I often have to add some options just to get the statements of the theorems to elaborate:

set_option synthInstance.maxHeartbeats 100000

In the future we might also want to add options that disable automatic implicit lambdas (see #53).

@dselsam
Copy link
Collaborator

dselsam commented Feb 27, 2022

It might be nice to bundle them all in one command, e.g. #mathlib_set_defaults

@gebner
Copy link
Member Author

gebner commented Feb 28, 2022

That's a good suggestion, but I'm not sure it's the best idea.

  1. In my experience, putting mathport configuration in mathlib4 is a bit of a maintenance headache. For example changing alignments requires adding it to mathlib4, then update mathlib4 in mathport, and then verify that the alignment actually works. I'd rather keep these things in the mathport repo if possible to make it easier to iterate on them.
  2. After porting, we might want to remove these options incrementally again. Having several lines makes it easier to clean up the "hackport" options again.

@digama0
Copy link
Member

digama0 commented Feb 28, 2022

An alignment is a relationship between a lean 3 mathlib definition and a mathlib4 definition; it does not intrinsically involve mathport. It might make sense for rapid iteration purposes to have mathport configuration that overrides these alignment indications, but for reasonably stable alignments that we want to keep I think we should be pushing them to mathlib4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants