Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instance naming heuristic has changed #106

Open
gebner opened this issue Feb 18, 2022 · 0 comments
Open

Instance naming heuristic has changed #106

gebner opened this issue Feb 18, 2022 · 0 comments

Comments

@gebner
Copy link
Member

gebner commented Feb 18, 2022

https://github.com/leanprover-community/mathlib3port/blob/67a51806c8dd940f81523244e4b9fb47ca980912/Mathbin/RingTheory/HahnSeries.lean#L379

instance : AddMonoidₓ (HahnSeries Γ R) where

-- ..

instance [AddCommMonoidₓ R] : AddCommMonoidₓ (HahnSeries Γ R) :=
  { HahnSeries.addMonoid with
    add_comm := fun x y => by
      ext
      apply add_commₓ }

Lean 3 generated the name hahn_series.add_monoid for the instance, Lean 4 now uses instAddMonoidHahnSeries by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gebner