Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

chore(data/rat/*): Rearrange imports #18609

Closed
wants to merge 3 commits into from
Closed

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Mar 18, 2023

The goal is to separate the field material on rat/nnrat from everything before. We achieve this by

  • removing the field and big operators material from data.rat.nnrat to data.rat.basic and data.rat.nnrat.lemmas
  • moving the field material from data.rat.order to data.rat.basic
  • proving a few lemmas by rfl rather than coe_hom.some_now_unavailable_lemma

No lemma has been renamed or changing attributes. Everything is only moves and proof fixing (or at least I intend it to be).

Open in Gitpod

@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. t-algebra Algebra (groups, rings, fields etc) labels Mar 18, 2023
@YaelDillies YaelDillies requested a review from a team as a code owner March 18, 2023 11:29
@YaelDillies
Copy link
Collaborator Author

Closed in favor of leanprover-community/mathlib4#10392.

@YaelDillies YaelDillies closed this Feb 9, 2024
@YaelDillies YaelDillies deleted the shuffle_nnrat branch February 9, 2024 22:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
awaiting-CI The author would like to see what CI has to say before doing more work. awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) too-late This PR was ready too late for inclusion in mathlib3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants