Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR into mathlib #66

Open
kckennylau opened this issue Jun 8, 2020 · 1 comment
Open

PR into mathlib #66

kckennylau opened this issue Jun 8, 2020 · 1 comment

Comments

@kckennylau
Copy link
Collaborator

I believe one should PR the content of this repo into mathlib bit by bit to preserve this repo. Afterall, a Chinese proverb says that "anything not PR'ed into mathlib is lost in time".

I imagine this will start with src/for_mathlib.

@jcommelin
Copy link
Member

I've been trying to get linear_ordered_comm_group_with_zero into mathlib. For that, I've

After that, linear_ordered_comm_group_with_zero can be PRd. And the next step is valuation/basic.

So yes, I'm slowly trying to get things to mathlib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants