Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to 4.8.0-rc1 #25

Closed
AdrienChampion opened this issue May 9, 2024 · 3 comments
Closed

bump to 4.8.0-rc1 #25

AdrienChampion opened this issue May 9, 2024 · 3 comments

Comments

@AdrienChampion
Copy link

AdrienChampion commented May 9, 2024

I'm starting to use lean-auto, and noticed it does not require std's stable branch but main instead, which does not build as it's now in 4.8.0-rc1.

I have a version of lean-auto that builds on 4.8.0-rc1 here. I don't think you'd want to merge it as is, but hopefully it can be useful as a blueprint for you.

The main things I had to accomodate are:

  • std is now batteries (and moved from leanprover to leanprover-community on github);
  • simp and other tactics behave slightly differently causing a few proofs to fail, solved by removing/adding minor things;
  • theorem-s now have to have type Prop, causing some of your theorems to become (sometimes noncomputable) def-s.

I think that's most of it.

Also, it seems some definitions are still under the Std namespace such as Std.Queue. So it might be a good idea to wait until 4.8.0 releases before updating, and probably require std batteries from its stable branch.

@PratherConid
Copy link
Collaborator

PratherConid commented May 21, 2024

@AdrienChampion I've just removed Std from lean-auto's dependencies. It seems that enough definitions/theorems have been moved to leanprover/lean4 such that lean-auto no longer needs to depend on Std. So, the renaming part is no longer necessary.

@PratherConid
Copy link
Collaborator

It still makes sense to wait for the stable release.

@dranov
Copy link
Contributor

dranov commented Jun 24, 2024

@PratherConid See #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants