Failed to acquire lock on

[ppascualv]

I'm receiving a Redlock::LockError Failed to acquire lock on "name-of-key" sometimes using the gem. I know this error comes from Redis but I would like to know how can I prevent it.
This is the code that we have at the moment:

class Locker
  extend Memoist

  DEFAULT_EXPIRATION = 5.seconds

  def with_lock(key, expiration: DEFAULT_EXPIRATION, retries: 1, wait: 0.1.seconds, &block)
    current_retry ||= 0
    lock!(key, expiration:, &block)
  rescue Redlock::LockError => e
    current_retry += 1
    raise e if current_retry >= retries

    sleep(wait)
    retry
  end

  private

  memoize def lock_manager
    Redlock::Client.new([Rails.application.credentials.redis.url])
  end

  def lock!(key, expiration: DEFAULT_EXPIRATION, &block)
    lock_manager.lock!(key, (expiration * 1000).to_i, &block)
  end
end

And this is how we call the lock:

Locker.new.with_lock("key") do
    action
end

[venalen]

Probably way too late on this, but I managed to get around this by explicitly using the RedisClient. So for your application:

Redlock::Client.new([ RedisClient.new(url: Rails.application.credentials.redis.url) ])

I noticed this nuance in the Compatibility section of the docs

[ppascualv]

I'm going to try it, thanks @venalen !

[ppascualv]

still happening

[tms-tham]

@ppascualv
Have you fix this issue? If not, how you deal with production?

[ppascualv]

We're handling it with the retry system, we substitute this

raise e if current_retry >= retries

to execute the block instead of raising the error @tms-tham