fix: fix error catching in TS package

ldclabs · Oct 20, 2024 · b6f4404 · b6f4404
1 parent cd7aacd
commit b6f4404
Show file tree

Hide file tree

Showing 7 changed files with 20 additions and 18 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -17,7 +17,7 @@ strip = true
 opt-level = 's'
 
 [workspace.package]
-version = "0.9.5"
+version = "0.9.6"
 edition = "2021"
 repository = "https://github.com/ldclabs/ic-oss"
 keywords = ["file", "storage", "oss", "s3", "icp"]

diff --git a/src/ic_oss_bucket/src/store.rs b/src/ic_oss_bucket/src/store.rs
@@ -1302,7 +1302,6 @@ pub mod fs {
                     }
 
                     checker(&file)?;
-
                     file.updated_at = now_ms;
                     file.filled += chunk.len() as u64;
                     if file.filled > max {
@@ -1313,16 +1312,18 @@ pub mod fs {
                         r.borrow_mut()
                             .insert(FileId(file_id, chunk_index), Chunk(chunk))
                     }) {
-                        None => {
-                            if file.chunks <= chunk_index {
-                                file.chunks = chunk_index + 1;
-                            }
-                        }
+                        None => {}
                         Some(old) => {
-                            file.filled -= old.0.len() as u64;
+                            if chunk_index < file.chunks {
+                                file.filled = file.filled.saturating_sub(old.0.len() as u64);
+                            }
                         }
                     }
 
+                    if file.chunks <= chunk_index {
+                        file.chunks = chunk_index + 1;
+                    }
+
                     let filled = file.filled;
                     if file.size > 0 && filled > file.size {
                         Err(format!(

diff --git a/src/ic_oss_ts/package.json b/src/ic_oss_ts/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ldclabs/ic_oss_ts",
-  "version": "0.9.5",
+  "version": "0.9.6",
   "type": "module",
   "description": "The Typescript version of the client SDK for the ic-oss cluster.",
   "license": "MIT",
@@ -20,6 +20,7 @@
   "files": [
     "candid",
     "dist",
+    "src",
     "package.json",
     "LICENSE",
     "README.md"

diff --git a/src/ic_oss_ts/src/queue.ts b/src/ic_oss_ts/src/queue.ts
@@ -25,7 +25,7 @@ export class ConcurrencyQueue {
 
       result
         .then(() => (this.#total += 1))
-        .catch(this.#abort)
+        .catch((err) => this.#abort(err))
         .finally(() => {
           this.#pending.delete(fn)
           this.#results.delete(result)

diff --git a/src/ic_oss_ts/src/types.ts b/src/ic_oss_ts/src/types.ts
@@ -46,7 +46,6 @@ export interface UploadFileChunksResult {
   id: number
   filled: number
   uploadedChunks: number[]
-  error?: unknown // if any error occurs during upload
 }
 
 export interface Progress {

diff --git a/src/ic_oss_ts/src/uploader.ts b/src/ic_oss_ts/src/uploader.ts
@@ -156,7 +156,8 @@ export class Uploader {
         content_type: []
       })
     } catch (err) {
-      rt.error = err
+      ;(err as any).data = rt
+      throw err
     }
 
     return rt