Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link modal not closing after changing seleciton or focus. #9

Open
SergeyOkishev opened this issue Jul 27, 2017 · 1 comment
Open

Link modal not closing after changing seleciton or focus. #9

SergeyOkishev opened this issue Jul 27, 2017 · 1 comment

Comments

@SergeyOkishev
Copy link

In my opinion link modal should be closed after editor looses focus or after changing selection on editor.

To reproduce: just select some text, click "link" then just select another part of text or click outside of editor and back. Every time u open toolbar there would be link modal.

Could be fixed by subscribing on "onEditorChange" and close modal window each time editor changed. This event would be raised by any kind of selection, focus loosing or editing.

P.S. same behaviour comes with any other pickers and kinda frustrating based on UX.

@SergeyOkishev
Copy link
Author

PR
This version didn`t work for now, event not rising. After fixing this one it would work for any focus/editing draftjs editor and close link modal window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant