Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a time provider to get the current system time #139

Closed
lcobucci opened this issue Nov 7, 2016 · 3 comments
Closed

Use a time provider to get the current system time #139

lcobucci opened this issue Nov 7, 2016 · 3 comments
Labels
Improvement
Milestone
4.0.0-alpha1

Comments

@lcobucci
Copy link
Owner

lcobucci commented Nov 7, 2016

With that we wouldn't allow null on methods that receives a DateTimeInterface, inject the time provider on the validation constraints and also on the configuration object.
@lcobucci lcobucci added this to the 4.0.0 milestone Nov 7, 2016
@lcobucci
Copy link
Owner Author

lcobucci commented Nov 7, 2016 •
edited
Loading

Does anyone have a suggestion for the package that can be used for this (wouldn't make sense to provide that interface here IMO)?

@lcobucci lcobucci mentioned this issue Nov 7, 2016
Closed
@lcobucci
Copy link
Owner Author

lcobucci commented Nov 7, 2016

Depends on #129 (sure)

lcobucci added a commit that referenced this issue May 7, 2017
@lcobucci
Use a time provider instead on ValidAt constraint
3ef710a 
So that we can separate the constraint initialisation from the the
validation itself and then be able to map validation constraints in a
dependency injection container.

Closes #139
lcobucci added a commit that referenced this issue May 7, 2017
@lcobucci
Use a time provider instead on ValidAt constraint
d40422a 
So that we can separate the constraint initialisation from the
validation itself and then be able to map validation constraints in a
dependency injection container.

Closes #139
@Ocramius
Copy link
Collaborator

Ocramius commented May 8, 2017

@lcobucci checked now, patch LGTM! 👍

Horikawaer added a commit to Horikawaer/jwt that referenced this issue Nov 3, 2022
@Horikawaer @lcobucci
Use a time provider instead on ValidAt constraint
3880039 
So that we can separate the constraint initialisation from the
validation itself and then be able to map validation constraints in a
dependency injection container.

Closes lcobucci/jwt#139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
4.0.0-alpha1
Development

No branches or pull requests
2 participants
@Ocramius @lcobucci