Skip to content

Commit

Permalink
Merge pull request #274 from lcobucci/fix-documentation-of-internal-c…
Browse files Browse the repository at this point in the history
…omponents

Fix documentation of internal components
  • Loading branch information
lcobucci authored Nov 11, 2018
2 parents c9704b7 + 3d72c12 commit 82be04b
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 2 deletions.
6 changes: 5 additions & 1 deletion src/Signer/BaseSigner.php
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ private function getKey($key)
/**
* Creates a hash with the given data
*
* @internal
*
* @param string $payload
* @param Key $key
*
Expand All @@ -67,7 +69,9 @@ private function getKey($key)
abstract public function createHash($payload, Key $key);

/**
* Creates a hash with the given data
* Performs the signature verification
*
* @internal
*
* @param string $expected
* @param string $payload
Expand Down
6 changes: 5 additions & 1 deletion src/Signer/Ecdsa.php
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,9 @@ private function extractSignature($value)
}

/**
* Returns the lenght of signature parts
* Returns the length of signature parts
*
* @internal
*
* @return int
*/
Expand All @@ -143,6 +145,8 @@ abstract public function getSignatureLength();
/**
* Returns the name of algorithm to be used to create the signing hash
*
* @internal
*
* @return string
*/
abstract public function getAlgorithm();
Expand Down
2 changes: 2 additions & 0 deletions src/Signer/Ecdsa/KeyParser.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@
/**
* Base class for ECDSA signers
*
* @internal
*
* @author Luís Otávio Cobucci Oblonczyk <[email protected]>
* @since 3.0.4
*/
Expand Down
4 changes: 4 additions & 0 deletions src/Signer/Hmac.php
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ public function doVerify($expected, $payload, Key $key)
/**
* PHP < 5.6 timing attack safe hash comparison
*
* @internal
*
* @param string $expected
* @param string $generated
*
Expand All @@ -65,6 +67,8 @@ public function hashEquals($expected, $generated)
/**
* Returns the algorithm name
*
* @internal
*
* @return string
*/
abstract public function getAlgorithm();
Expand Down
2 changes: 2 additions & 0 deletions src/Signer/Rsa.php
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ private function validateKey($key)
/**
* Returns the algorithm name
*
* @internal
*
* @return string
*/
abstract public function getAlgorithm();
Expand Down

0 comments on commit 82be04b

Please sign in to comment.