Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread safety issue #277

Open
layters opened this issue May 19, 2024 · 0 comments
Open

Thread safety issue #277

layters opened this issue May 19, 2024 · 0 comments
Labels
⬆️ high priority High priority issues good first issue Good for newcomers 🐞 bug Something isn't working 🆘 help wanted Extra attention is needed urgent Required to move forward

Comments

@layters
Copy link
Owner

layters commented May 19, 2024

Details

So the code for the backend (neroshop daemon) is not thread safe and sometimes random segment faults occur and I'd often get deadlocks when using mutexes. I have no knowledge in threads or thread-safety practices so I need someone far more knowledgeable than me who can help make this as thread-safe as possible.

There are countless threads being used and many threads are within other threads which probably makes the issue much worse I think.

Files to focus on

src/daemon/main.cpp
src/core/protocol/node.cpp
src/core/protocol/routing_table.cpp
src/core/protocol/key_mapper.cpp

@layters layters added 🐞 bug Something isn't working 🆘 help wanted Extra attention is needed good first issue Good for newcomers ⬆️ high priority High priority issues urgent Required to move forward labels May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⬆️ high priority High priority issues good first issue Good for newcomers 🐞 bug Something isn't working 🆘 help wanted Extra attention is needed urgent Required to move forward
Projects
None yet
Development

No branches or pull requests

1 participant