New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possibly incorrect test when checking for (name, email) tuple #167

Open

Cheaterman opened this issue May 30, 2023 · 0 comments

Cheaterman commented May 30, 2023

https://github.com/lavr/python-emails/blob/eb1adb459116bcc66b7e413a468e1a97336034d9/emails/utils.py#LL134C69-L134C70

I think this test might be incorrect? Perhaps the line should read as follows:

if isinstance(e, string_types) and (not n or isinstance(n, string_types)):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment