Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeprecationWarning: The punycode module is deprecated. Please use a userland alternative instead. #11475

Open
samj opened this issue Dec 7, 2024 · 6 comments
Labels
backlog We'll get to it... eventually... bug It's a bug cli CLI app specific issue

Comments

@samj
Copy link

samj commented Dec 7, 2024

Operating system

macOS

Joplin version

3.0.1

Desktop version info

joplin 3.0.1 (prod, darwin)

Client ID: 3f4345a7f86b42b7a88ea3ce5a48d6b0
Sync Version: 3
Profile Version: 47
Keychain Supported: Yes

Current behaviour

% joplin version
(node:12239) [DEP0040] DeprecationWarning: The punycode module is deprecated. Please use a userland alternative instead.
(Use node --trace-deprecation ... to show where the warning was created)
Joplin CLI Client

Copyright © 2016-2024 Laurent Cozic
joplin 3.0.1 (prod, darwin)

Client ID: 3f4345a7f86b42b7a88ea3ce5a48d6b0
Sync Version: 3
Profile Version: 47
Keychain Supported: Yes

Expected behaviour

No deprecation warning.

Logs

No response

@samj samj added the bug It's a bug label Dec 7, 2024
@lendrik-kumar
Copy link

while working i discovered a issue with react and react hooks versions, what should i do . Should i update or downgrade the react version and test it??

@samj
Copy link
Author

samj commented Dec 8, 2024 via email

@lendrik-kumar
Copy link

ok no problem, I'll find some other way

lendrik-kumar added a commit to lendrik-kumar/joplin that referenced this issue Dec 9, 2024
personalizedrefrigerator added a commit to personalizedrefrigerator/joplin that referenced this issue Dec 11, 2024
@personalizedrefrigerator
Copy link
Collaborator

If I generate a stack trace using NODE_OPTIONS=--trace-deprecation yarn start, the warning is traced to:

  • markdown-it v13.0.2. Based on the changelog for markdown-it v14, upgrading may fix the issue.
  • whatwg-url v5.0.0 used by node-fetch v2.

If I:

  1. Upgrade markdown-it to v14.1.0 and
  2. Remove the node-fetch dependency,

then the CLI application starts without the warning.

@personalizedrefrigerator personalizedrefrigerator added cli CLI app specific issue medium Medium priority issues backlog We'll get to it... eventually... and removed medium Medium priority issues labels Dec 11, 2024
@personalizedrefrigerator
Copy link
Collaborator

I'm linking to a related commit: 817f3bc. Thank you @pedr for fixing the issue!

The fix should be in v3.2.

@samj
Copy link
Author

samj commented Dec 12, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog We'll get to it... eventually... bug It's a bug cli CLI app specific issue
Projects
None yet
Development

No branches or pull requests

3 participants