diff --git a/interfaces/client_interface.go b/interfaces/client_interface.go index d244d54c..34473b0d 100644 --- a/interfaces/client_interface.go +++ b/interfaces/client_interface.go @@ -195,7 +195,7 @@ type LDClientEvents interface { // LDClientInterface defines the basic SDK client operations implemented by LDClient. // // This includes all methods for evaluating a feature flag or generating analytics events, as defined by -// LDEvaluations and LDEvents. It does not include general control operations like Flush(), Finish(), or +// LDEvaluations and LDEvents. It does not include general control operations like Flush(), Close(), or // GetDataSourceStatusProvider(). type LDClientInterface interface { LDClientEvaluations diff --git a/internal/broadcasters.go b/internal/broadcasters.go index e8c6df69..140ce8de 100644 --- a/internal/broadcasters.go +++ b/internal/broadcasters.go @@ -10,7 +10,7 @@ import ( // // The standard pattern is that AddListener returns a new receive-only channel; RemoveListener unsubscribes // that channel, and closes the sending end of it; Broadcast sends a value to all of the subscribed channels -// (if any); and Finish unsubscribes and closes all existing channels. +// (if any); and Close unsubscribes and closes all existing channels. // Arbitrary buffer size to make it less likely that we'll block when broadcasting to channels. It is still // the consumer's responsibility to make sure they're reading the channel. diff --git a/internal/datasource/streaming_data_source.go b/internal/datasource/streaming_data_source.go index 24c82732..b0b57a50 100644 --- a/internal/datasource/streaming_data_source.go +++ b/internal/datasource/streaming_data_source.go @@ -144,7 +144,7 @@ func (sp *StreamProcessor) consumeStream(stream *es.Stream, closeWhenReady chan< if !ok { // COVERAGE: stream.Events is only closed if the EventSource has been closed. However, that // only happens when we have received from sp.halt, in which case we return immediately - // after calling stream.Finish(), terminating the for loop-- so we should not actually reach + // after calling stream.Close(), terminating the for loop-- so we should not actually reach // this point. Still, in case the channel is somehow closed unexpectedly, we do want to // terminate the loop. return diff --git a/internal/datasourcev2/streaming_data_source.go b/internal/datasourcev2/streaming_data_source.go index 8e8788e0..9fa17af1 100644 --- a/internal/datasourcev2/streaming_data_source.go +++ b/internal/datasourcev2/streaming_data_source.go @@ -153,7 +153,7 @@ func (sp *StreamProcessor) consumeStream(stream *es.Stream, closeWhenReady chan< if !ok { // COVERAGE: stream.Events is only closed if the EventSource has been closed. However, that // only happens when we have received from sp.halt, in which case we return immediately - // after calling stream.Finish(), terminating the for loop-- so we should not actually reach + // after calling stream.Close(), terminating the for loop-- so we should not actually reach // this point. Still, in case the channel is somehow closed unexpectedly, we do want to // terminate the loop. return