Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop dead branch in proc macro from emitting clippy::missing_panics_doc #3595

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: stop dead branch in proc macro from emitting clippy::missing_panics_doc #3595

wants to merge 1 commit into from
+3 −1

Conversation

paolobarbolini
Copy link
Contributor

fixes #3594

abonander
abonander reviewed Nov 26, 2024
View reviewed changes
sqlx-macros-core/src/query/args.rs
::std::panic!();
// `panic!` would be enough here but we would then get a warning on `clippy::missing_panics_doc`
// SAFETY: this branch is never reached.
unsafe { ::std::hint::unreachable_unchecked() }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like emitting unsafe from the macros for any reason, honestly. Does unreachable!() emit the same lint warning?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, just #[allow] the lint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abonander abonander abonander left review comments

@humb1t humb1t humb1t approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dead branch in proc macro triggers clippy::missing_panics_doc
3 participants
@paolobarbolini @abonander @humb1t