Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appearances of @@ in expl3 commands in source2e #1596

Open
mbertucci47 opened this issue Dec 23, 2024 · 1 comment
Open

appearances of @@ in expl3 commands in source2e #1596

mbertucci47 opened this issue Dec 23, 2024 · 1 comment
Labels
bug (documentation) category base (latex) fixed in dev Fixed in development branch, not in stable release

Comments

@mbertucci47
Copy link
Contributor

Brief outline of the bug

There are several spots in source2e where @@ is printed instead of the module name. I'm not sure if something is wrong with the docstrip process or if the module wasn't properly set in the dtx.

lthooks

  • \g_@@_⟨hook⟩_code_prop to \@@_toplevel␣⟨hook⟩, 4.4.1 The data structures of a hook
  • @@_rule_gclear:nnn, text before the definition of \ClearHookRule (this is just missing a \cs)

ltmarks

  • \@@_update_singlecol_structures: or \@@_update_dblcol_structures: in description of \mark_copy_structure:nn

ltfilehook

  • \@@_set_curr_file:nNN and \@@_set_curr_file_assign:nnnNN. In the \IncludeInRelease, @@_set_curr_file:nNN is missing a backslash.

Change History

Many instances here. I won't list them all but they're easy to find by searching @@_.


If the cause is easy to identify I'm happy to go through and fix them.

@FrankMittelbach
Copy link
Member

FrankMittelbach commented Dec 25, 2024

lthooks: \DescribeMacro is not set up to handle @@ convention (as one normally doesn't describe internal commands this way). Simple approach, just use the real name in that case.

\changes entries are also not handled (which I guess they should). For now I manually fixed those.

Change history: I started to fix those, but then reverted back. Reason: the change log is really code level, and so if you see \@@_foo: got changed then this matches what you see in the source.

FrankMittelbach added a commit that referenced this issue Dec 25, 2024
@FrankMittelbach FrankMittelbach added fixed in dev Fixed in development branch, not in stable release bug (documentation) category base (latex) labels Dec 25, 2024
@github-project-automation github-project-automation bot moved this to Pool (unscheduled issues) in upcoming LaTeX2e releases Dec 25, 2024
@FrankMittelbach FrankMittelbach moved this from Pool (unscheduled issues) to Done in dev in upcoming LaTeX2e releases Dec 25, 2024
@FrankMittelbach FrankMittelbach added this to the Release 2025 Spring milestone Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug (documentation) category base (latex) fixed in dev Fixed in development branch, not in stable release
Projects
Status: Done in dev
Development

No branches or pull requests

2 participants