Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration test improvements (bind with kryoptic and disabling early initialization) #450

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Integration test improvements (bind with kryoptic and disabling early initialization) #450

merged 3 commits into from
Oct 10, 2024

Conversation

The-Mule
Copy link
Collaborator

@The-Mule The-Mule commented Oct 10, 2024 •
edited by simo5
Loading

Description

Changes:

  1. Adds support for all three tokens to bind integration test (re-using already present init scripts to test tokens).
  2. Disables early initialization quirk for both bind and httpd tests.
  3. Updates integration tests actions by adding kryoptic setup, bind test is currently only enabled for kryoptic since bind bug (https://bugzilla.redhat.com/show_bug.cgi?id=2277997) prevents it from running with softokn or softhsm successfully

Fixes #266

Checklist

N/A

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • This feature/change has adequate documentation added
  • Code conform to coding style that today cannot yet be enforced via the check style test
  • Commits have short titles and sensible commit messages
  • Coverity Scan has run if needed (code PR) and no new defects were found

@The-Mule The-Mule force-pushed the bind-test-with-kryoptic branch from 5da5c42 to 0bb8774 Compare October 10, 2024 15:35
@The-Mule The-Mule marked this pull request as draft October 10, 2024 15:41
@The-Mule
Copy link
Collaborator Author

I accidentally disabled libssh test, let me fix that quickly...

@The-Mule The-Mule force-pushed the bind-test-with-kryoptic branch 3 times, most recently from f3011dc to db4e135 Compare October 10, 2024 16:37
@The-Mule The-Mule marked this pull request as ready for review October 10, 2024 16:42
@The-Mule
Copy link
Collaborator Author

Fixed. Bind took 59 second even with all kryoptic cloning and building and hence I guess caching is doing its work.

@The-Mule The-Mule requested a review from simo5 October 10, 2024 16:43
simo5
simo5 approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@simo5 simo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simo5 simo5 merged commit c7fb177 into latchset:main Oct 10, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simo5 simo5 simo5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Digest + Sign operation no longer working (in default config)
2 participants
@The-Mule @simo5