Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renouncing Ownership #18

Open
taitruong opened this issue Aug 17, 2023 · 2 comments
Open

Renouncing Ownership #18

taitruong opened this issue Aug 17, 2023 · 2 comments

Comments

@taitruong
Copy link
Contributor

This action is quite critical and executes it without confirmation. If owner e.g. accidentally does this, contract will be immutable once and forever.

I believe existing TransferOwnership action can be adjusted by having new_owner: Option<String> instead of new_owner: String. Then in AcceptOwnership we just need to check whether sender is owner and then set owner None. This way RenounceOwnership would be obsolete.

@larry0x, wdyt?

@taitruong
Copy link
Contributor Author

@CyberHoward pls have a look at this. Imo we can simplify this and make it even more secure.

@CyberHoward
Copy link
Collaborator

I don't think this is worth changing the API for. Having the ability to do destructive actions will always be present when managing smart-contracts. It's up to the person(s) that manage these smart-contracts to ensure that only the correct calls are performed. Be it through the use of a multi-sig or other tooling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants