Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messed up timezones after PR #417 #422

Closed
maciek-szn opened this issue Nov 25, 2024 · 5 comments
Closed

Messed up timezones after PR #417 #422

maciek-szn opened this issue Nov 25, 2024 · 5 comments
Assignees

Comments

@maciek-szn
Copy link

Pulse Version

1.2.6

Laravel Version

11.33.2

PHP Version

8.3.13

Livewire Version

3.5.12

Database Driver & Version

No response

Description

After #417 timezones are messed up much more than before.

It's 16:56 CET here now.

CPU and memory graphs show UTC time (so 1 hour back):
obraz

Queues graph shows CET time (correct):
obraz

However queues card title tooltip shows some mystery timezone (1 hour forward, definitely not CET):
obraz

Custom cards just use UTC. I'm guessing they should be manually modified by their authors, but do the authors know about it?

Steps To Reproduce

Just observe the Pulse cards.

@timacdonald timacdonald self-assigned this Nov 25, 2024
@timacdonald
Copy link
Member

timacdonald commented Nov 25, 2024

Thanks for raising this one. Looks like the graph update mechanism was missed on this one for the memory and CPU stats, as they slightly vary from the queue implementation.

I've opened a PR to address the wrong formatting after updates: #423

If custom cards want to format their dates, they will need to manually make this happen. There is a global window.formatDate function available if they wish to use it. But they can also implement their own formatting if they wish.

I'm unable to replicate the issue with the queues card date. If you can provide the steps to reproduce the problem I will reopen the issue and dive into it.

@maciek-szn
Copy link
Author

I'm unable to replicate the issue with the queues card date. If you can provide the steps to reproduce the problem I will reopen the issue and dive into it.

There are no specific steps to reproduce. It just works that way. I can describe the server and client configuration.

Server:

  • OS: Ubuntu 24.04
  • OS timezone: Europe/Warsaw
  • Laravel app timezone: Europe/Warsaw
  • php.ini timezone: Europe/Warsaw

Client:

  • OS: Windows (tested on 10 & 11)
  • OS timezone: Europe/Warsaw
  • browser: Firefox 132.0.2, Chrome 131.0.6778.86

The tooltip issue occurs not only on the Queues card, but on other cards as well.

@timacdonald
Copy link
Member

Hmm. Can you please try upgrading to v1.2.7, which we released yesterday, and then running php artisan view:clear and let me know which issues are remaining?

@timacdonald timacdonald reopened this Nov 27, 2024
@maciek-szn
Copy link
Author

maciek-szn commented Nov 28, 2024

Sure. Unfortunately nothing has changed. It's 20:13 CET here and the tooltip shows 21:13 CET.

obraz

The CPU and Memory graphs work fine in 1.2.7.

@timacdonald
Copy link
Member

Appreciate you checking this again.

I've opened a PR to fix this: #425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants