Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

one composer package support multiple laravel versions #13

Open
sinkcup opened this issue Jun 8, 2019 · 0 comments
Open

one composer package support multiple laravel versions #13

sinkcup opened this issue Jun 8, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@sinkcup
Copy link
Member

sinkcup commented Jun 8, 2019

because of different laravel versions have different dependencies, I use different branches to support:

  • laravel-5-5: bootstrap 3.3, socialite 3.3
  • laravel-5-6: bootstrap 4.0, socialite 3.3
  • master(laravel 5.7): bootstrap 4.0, socialite 4.1

it's difficult to maintain.

actually, there are a few different files:

  • views
  • composer.json

so, maybe I should use one composer package to support multiple laravel versions.

@sinkcup sinkcup self-assigned this Jun 8, 2019
@sinkcup sinkcup added the enhancement New feature or request label Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant