Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change documentation heading #98

Open
ksuderman opened this issue Aug 16, 2019 · 2 comments
Open

Change documentation heading #98

ksuderman opened this issue Aug 16, 2019 · 2 comments
Assignees

Comments

@ksuderman
Copy link

Change headings from Properties to Features in the vocabulary pages.

The code uses a Map named features but the headings in the documentation are "Properties". These should be consistent.

@ksuderman ksuderman self-assigned this Aug 16, 2019
@ksuderman ksuderman mentioned this issue Aug 16, 2019
@keighrim
Copy link
Member

I think this can be a more complicated problem than just changing the title of the table(s) on the vocab item web page. As per the JSON schema, Annotation object can have @type, id, label, start, end, and features and metadata, so there is a caste that divides between start,end (as first-class citizens) and all other features (dumped in second-class features car).

@marcverhagen
Copy link
Contributor

There is probably no problem here since all this does it update what is printed on the vocabulary html pages. We would still need to clarify this issue in the specifications, but it sounds reasonable to say that the vocabulary defines features, and that in LIF some of those features live on the annotation type and some in the features dictionary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants