Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Events and Times #56

Open
marcverhagen opened this issue Jun 6, 2017 · 5 comments
Open

Adding Events and Times #56

marcverhagen opened this issue Jun 6, 2017 · 5 comments
Assignees
Labels
Milestone

Comments

@marcverhagen
Copy link
Contributor

marcverhagen commented Jun 6, 2017

It is probably not very controversial to use Event here and we could go with the TimeML attributes. My hunch would be to not add things like Process and State as subtypes, but deal with them in the same way as we deal with kinds of NamedEntities.

As for times, is it okay to use Timex or does that get us to close to Timex2 and Timex3 and is something more generic like TimeExpression better?

@nancyide
Copy link
Contributor

nancyide commented Jun 6, 2017 via email

@marcverhagen
Copy link
Contributor Author

Still much shorter than DependencyStructure so there is precedent.

@ksuderman
Copy link

I like the brevity of Timex, but I think it's too close to Timex2 and Timex3, so I think we have to go with TimeExpression. Everything else is spelled out in full so it would be consistent.

@ksuderman ksuderman added this to the 1.2.0 milestone Nov 8, 2018
@marcverhagen marcverhagen modified the milestones: 1.2.0, 1.3.0 Nov 12, 2018
@ksuderman
Copy link

Bump. I notice this is marked with milestone 1.3.0 which is the next version of the vocabulary to be released. I don't think there is anything controversial here so we should just go ahead and do it.

To backtrack on my above comment, I think we should use Timex; that is just the abbreviated name, the actual discriminator will be http://vocab.lappsgrid.org/Timex.

@ksuderman ksuderman added the ready label Mar 8, 2019
@keighrim
Copy link
Member

keighrim commented Mar 8, 2019

How about TimeEx or TimeExp?

@marcverhagen marcverhagen self-assigned this Apr 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants