Refactor json_schema.py
to_regex
as a class, subclass to allow YAML generation
#36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Refactor
json_schema.py
to be more coherent and extensible. Use extensibility to implement JSON Schema to yaml.Changes
TODO, finish this section
Behavioral Changes
A number of changes have been made to conform with the JSON Schema spec.
This needs to be part of the release notes and documentation
including but not limited to:
anyOf
: Previously brokenallOf
: Previously brokenoneOf
: Disabled, not feasibleJSON Schema Compliance
This is a large change-set. To verify correctness, in addition to ensuring current tests pass,
test_json_schema_full.py
tests compliance with JSON Schema by retrieving 1,245 test cases from the official json-schema.org test suite.On this Branch
NotImplementedError
On
main
TODO
json_schema
so its clean and extensibleFurther Work
NotImplementedError
conditions. There are ~20 (mostly different key types)