Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPIC crashes if the decomposition leaves the grid size as nx/ny/nz=1 #28

Open
rfbird opened this issue Sep 5, 2018 · 1 comment
Open

Comments

@rfbird
Copy link
Contributor

rfbird commented Sep 5, 2018

This is obviously not a very likely scenario, as we run on meshes much bigger than this, but it may be a useful case for testing computational intensive modules (and writing unit tests etc).

The crux of the problem seems to come down to a check that, for each dimension, does:

const float px = (nx>1) ? g->rdx : 0;

If n_=1 it will set p_ to be 0. This is then used in a division (alphadt = 0.3888889/( px*px + py*py + pz*pz ); ) so inf/nans propagates throughout anything that touches the fields.

@rfbird
Copy link
Contributor Author

rfbird commented Sep 24, 2018

This is because this calculation uses local grid size (nx) instead of global. Should be an easy fix is the proc has access to global nx size

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant