-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change the Artifact
to be folder-based
#286
Conversation
be3033a
to
66f91f5
Compare
46e5fa1
to
19c5e28
Compare
19c5e28
to
c796e4e
Compare
Artifact
to be folder-basedArtifact
to be folder-based
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! I think it mostly looks good, just one comment right now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One minor comment
Currently we implement the
Artifact
based on the pickle.This requires to load / save the files.
This PR changes the
Artifact
to be folder-based.There is no need to load / save any more.
All the files under the
cwd
(current working directory) will be treated as the files inside the Artifact.Also we want to keep the
chat_with_artifacts
running in the same environment with the code_interpreter. So we don't have to maintain "local" and "remote".Local test
Code:
Result:
Also tested the
view_media_artifact
action, the result looks good now.