Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the behavior if live dependencies can't be inferred? #122

Open
falexwolf opened this issue Jul 7, 2022 · 2 comments
Open

What is the behavior if live dependencies can't be inferred? #122

falexwolf opened this issue Jul 7, 2022 · 2 comments

Comments

@falexwolf
Copy link
Member

and how would the user learn about it?

I'm just running into this case, which confuses me as two packages don't list versions.
image

@Koncopd
Copy link
Member

Koncopd commented Jul 7, 2022

Hm, do you have them in the current environment? If the packages are not in the current environment, then the versions are not given.

@falexwolf falexwolf changed the title What is the behavior if live dependencies can't be inferred What is the behavior if live dependencies can't be inferred? Jul 7, 2022
@falexwolf
Copy link
Member Author

I think I don't have them in the current environment! It's a notebook from someone else (not published), and it seems the dependencies weren't fully specified in the pyproject.toml because this notebook is more of a note (a potential post) on design choices made for building readfcs.

I think it'd be super super cool if the output up there would show fcsparser==not-installed pytometry==not-installed or something similar.

Wait, no, then the user can't copy paste anymore. Hmmm, maybe, show a logging output instead with a warning saying: logger.warning("Two of the dependencies are not installed: fcsparser, pytometry. And it prints that warning right below the header?

And then the user knows to run pip install on these to run the notebook? Does that sound like a reasonable UX?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants