Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Mail\Message produced output not usable by Storage\Message #43

Open
michalbundyra opened this issue Jan 15, 2020 · 1 comment
Open
Labels
Awaiting Author Updates Bug Something isn't working

Comments

@michalbundyra
Copy link
Member

this shows the problem zend-mail is having:

mail created with Mail\Message and serialized into raw
and then loaded with Storage\Message causes parse error if the $text contains double unix newlines (\n\n).

        $text = "Hello, bödi tekst\n\nBye";

        $part = new Mime\Part($text);
        $part->type = 'text/plain';
        $part->charset = 'UTF-8';

        $mime = new Mime\Message();
        $mime->addPart($part);

        $message = new Mail\Message();
        $message->setEncoding('UTF-8');
        $message->setBody($text);

        $raw = $message->toString();
        $message = new Storage\Message(['raw' => $raw]);

this throws on $message = new Storage\Message(['raw' => $raw]);

`


Originally posted by @glensc at zendframework/zend-mail#159

@michalbundyra
Copy link
Member Author

This repository has been moved to laminas/laminas-mail. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas/laminas-mail to another directory.
  • Copy the files from the second bullet point to the clone of laminas/laminas-mail.
  • In your clone of laminas/laminas-mail, commit the files, push to your fork, and open the new PR.
    We will be providing tooling via laminas/laminas-migration soon to help automate the process.

Originally posted by @weierophinney at zendframework/zend-mail#159 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Author Updates Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant