Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to documentation in readme is broken #28

Closed
meidlinga opened this issue Mar 3, 2022 · 7 comments · Fixed by #29
Closed

Link to documentation in readme is broken #28

meidlinga opened this issue Mar 3, 2022 · 7 comments · Fixed by #29

Comments

@meidlinga
Copy link
Contributor

Bug Report

Summary

Link to documentation https://docs.laminas.dev/laminas-cache-storage-adapter-redis/ in readme is broken and leads to a 404 on github pages.

@meidlinga meidlinga added the Bug Something isn't working label Mar 3, 2022
@boesing
Copy link
Member

boesing commented Mar 4, 2022

Yes, this stands for all adapters. Sorry for this.
You can find documentation at https://docs.laminas.dev/laminas-cache/v3/storage/adapter/

We are still investigating a proper way to refactor the documentation as it is currently not that optimized.

@meidlinga
Copy link
Contributor Author

Thanks for the link. Do you mean the laminas-cache alternative in general? I think linking https://docs.laminas.dev/laminas-cache/v3/storage/adapter/#redis-adapter would be a good alternative.

@boesing boesing added Documentation and removed Bug Something isn't working labels Mar 4, 2022
@boesing
Copy link
Member

boesing commented Mar 4, 2022

@meidlinga Yah, but we would prefer to have dedicated pages for every cache adapter.
But since we have ripped out the cache adapters last year, we haven't had time to investigate further documentation changes.

Maybe at some point we will provide redirects for the supported cache adapters to their new pages within the documentation website.

As of now, all documentations regarding any cache adapter is part of laminas-cache itself (in its repository).
The idea is to move all adapter specific documentations to the adapter repositories and then merge them back to the cache adapter when building docs. Sadly, as of now, it always requires a release for laminas-cache to actually build documentation. Thats one of the things we are still investigating as I don't see that we create patch releases for laminas-cache just to roll out documentation releases of new versions of several cache adapters.

I keep this ticket open to keep track of the fact that the link to the documentation is broken.
If you want to, you can send a patch to fix the README file. I'm open to merge that to the latest minor branch 👍🏼

@froschdesign
Copy link
Member

All these links are wrong in the readme files:

@boesing

The idea is to move all adapter specific documentations to the adapter repositories and then merge them back to the cache adapter when building docs.

I am still working on the problem and am currently testing something like this:

- Redis: '!import https://github.com/laminas/laminas-cache-storage-adapter-redis?branch=…?docs_dir=…'

@froschdesign
Copy link
Member

meidlinga added a commit to meidlinga/laminas-cache-storage-adapter-redis that referenced this issue Mar 4, 2022
Points link in README to documentation for laminas-cache
refs: laminas#28
@meidlinga
Copy link
Contributor Author

@boesing , @froschdesign : I opened a PR for a temporary fix, as you suggested. Thanks for the detailed explanation of the underlying problem.

meidlinga added a commit to meidlinga/laminas-cache-storage-adapter-redis that referenced this issue Mar 4, 2022
Points link in README to documentation for laminas-cache
refs: laminas#28

Signed-off-by: meidlinga <[email protected]>
@boesing boesing linked a pull request Mar 7, 2022 that will close this issue
@boesing
Copy link
Member

boesing commented Mar 7, 2022

Closed with #29

@boesing boesing closed this as completed Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants