Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(levm): fixing vm arithmetic tests changes #1333

Merged
merged 45 commits into from
Nov 29, 2024

Conversation

maximopalopoli
Copy link
Contributor

@maximopalopoli maximopalopoli commented Nov 28, 2024

Motivation

The goal is to make pass the tests in the arithmetic subfolder of the VMTests folder.

Description

These changes are mostly local, so don't change much in the passed tests count.

@maximopalopoli maximopalopoli added ef-tests Hive tests, execution-spec-tests levm Lambda EVM implementation labels Nov 28, 2024
@maximopalopoli maximopalopoli self-assigned this Nov 28, 2024
@maximopalopoli maximopalopoli changed the title Fix: Use U256 in checked_shift right and left fix(levm): fixing vm arithmetic tests changes Nov 28, 2024
Base automatically changed from levm/fix/vmTests-fix-changes to main November 29, 2024 19:03
@maximopalopoli maximopalopoli marked this pull request as ready for review November 29, 2024 19:53
@maximopalopoli maximopalopoli requested a review from a team as a code owner November 29, 2024 19:53
Copy link
Contributor

@ilitteri ilitteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

maximopalopoli and others added 2 commits November 29, 2024 18:10
Co-authored-by: Ivan Litteri <[email protected]>
@ilitteri ilitteri enabled auto-merge November 29, 2024 21:20
@ilitteri ilitteri added this pull request to the merge queue Nov 29, 2024
Merged via the queue into main with commit 9981422 Nov 29, 2024
4 checks passed
@ilitteri ilitteri deleted the levm/fix/vmArithmeticTests-changes branch November 29, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ef-tests Hive tests, execution-spec-tests levm Lambda EVM implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants