Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all p2p protocol info! messages by debug! messages #1134

Closed
Tracked by #19
ElFantasma opened this issue Nov 11, 2024 · 0 comments · Fixed by #1174
Closed
Tracked by #19

Replace all p2p protocol info! messages by debug! messages #1134

ElFantasma opened this issue Nov 11, 2024 · 0 comments · Fixed by #1174
Labels
network Issues related to network communication
Milestone
[L1] 4 - P2P Network

Comments

@ElFantasma
Copy link
Contributor

We are flooding the console. We should use debug! messages instead.
Also we should clean up the messages we want to show in console, even for debug level.
@ElFantasma ElFantasma added the network Issues related to network communication label Nov 11, 2024
@ElFantasma ElFantasma added this to the [L1] 4 - P2P Network milestone Nov 11, 2024
This was referenced Nov 11, 2024
Open
Merged
@h3lio5 h3lio5 mentioned this issue Nov 14, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 14, 2024
@ElFantasma
feat(l1): implement missing p2p message handlers (#1136)
ef5e161 
**Motivation**
`p2p` messages `Disconnect`, `Ping` and `Pong` handlers where not
implemented

**Description**

- Improved `Disconnect` message handler
- Now we send `Ping` messages every 15 seconds (same as go-ethereum)
- We ignore `Pong` messages (same as go-ethereum)

Closes #1030 

**New Related issues**
#1134 
#1135
github-merge-queue bot pushed a commit that referenced this issue Nov 27, 2024
@h3lio5 @ElFantasma
chore(l1): replace info! with debug! tracing log (#1174)
203ef4a 
**Motivation**

Replace `info!` tracing logs with `debug!` to avoid flooding the
console.

Closes #1134

---------

Co-authored-by: ElFantasma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
network Issues related to network communication
Projects
ethrex_l1
Status: Done
Milestone
[L1] 4 - P2P Network
Development

Successfully merging a pull request may close this issue.

chore(l1): replace info! with debug! tracing log h3lio5/lambda_ethereum_rust
1 participant
@ElFantasma