Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auxiliary function that constructs ordered builtin list #1869

Open
JulianGCalderon opened this issue Nov 6, 2024 · 0 comments
Open

Add auxiliary function that constructs ordered builtin list #1869

JulianGCalderon opened this issue Nov 6, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@JulianGCalderon
Copy link
Contributor

Sometimes in the code we need an ordered list of builtins:

const BUILTIN_ORDERED_LIST: &[BuiltinName] = &[
  BuiltinName::output,
  BuiltinName::pedersen,
  BuiltinName::range_check,
  BuiltinName::ecdsa,
  BuiltinName::bitwise,
  BuiltinName::ec_op,
  BuiltinName::keccak,
  BuiltinName::poseidon,
  BuiltinName::range_check96,
  BuiltinName::add_mod,
  BuiltinName::mul_mod,
];

The list is repeated an some places of the code and sometimes we forget to update it, leading to bugs. We could define a function that constructs the list and use it everywhere else.

@JulianGCalderon JulianGCalderon added the enhancement New feature or request label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant