Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] .. in path gets collapsed after 9.0.2 #1816

Open
1 of 3 tasks
vpzomtrrfrt opened this issue Sep 6, 2024 · 2 comments
Open
1 of 3 tasks

[fix] .. in path gets collapsed after 9.0.2 #1816

vpzomtrrfrt opened this issue Sep 6, 2024 · 2 comments
Labels

Comments

@vpzomtrrfrt
Copy link

vpzomtrrfrt commented Sep 6, 2024

Describe the bug

Node.js version: 20.15.1

OS version: Gentoo Linux rolling

Description: superagent started attempting to canonicalize URL paths in 9.0.2

Actual behavior

.. in paths gets interpreted by superagent, e.g. /api/v2/../error gets sent as /api/error.

Expected behavior

Paths should be sent as-is, or at least this should have waited for a major release

Code to reproduce

require("superagent").get("http://localhost:3000/api/v2/../error").then(console.log, console.error)

Checklist

  • I have searched through GitHub issues for similar issues.
  • I have completely read through the README and documentation.
  • I have tested my code with the latest version of Node.js and this package and confirmed it is still not working.
@vpzomtrrfrt vpzomtrrfrt added the Bug label Sep 6, 2024
@vpzomtrrfrt vpzomtrrfrt changed the title [fix] .. in path gets collapsed after [fix] .. in path gets collapsed after 9.0.2 Sep 6, 2024
@vpzomtrrfrt
Copy link
Author

Bisecting shows 7e20ced as breaking this

@titanism
Copy link
Collaborator

titanism commented Sep 6, 2024

PR welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants