-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tolerations, nodeSelectors, etc should be set per workload #133
Comments
Hi @treyhyde, thanks for bringing this issue to our attention! Two clarification questions for you:
|
yes and yes, sorry for the confusion |
@treyhyde, awesome! We can make those changes. Thank you for raising the issue! |
great thanks, I might have to disable the scanner until they are. Thanks for the followup. |
This is really preventing adoption of newer lacework features (things that require the clusteragent) |
Thanks for the follow up. We are working on getting this in an upcoming release. |
@treyhyde per workload tolerations and node selectors are released as part of 6.7 version release. Please let us know if this resolves the installation issues you faced. |
@rnalexlacework The syntax is a little awkward but seems to be ok to separate the tolerations of the cluster vs node agents. I don't see a "nodeSelector" for the "deployment" available. Just looked to fix our "proxy-scanner" config as well and there are even fewer options. |
Unfortunately, it is still not possible to set tolerations for deployments of |
If I set a toleration to allow the node agent to work on all the nodes, the scanner process also gets that toleration which is very undesirable
The text was updated successfully, but these errors were encountered: