Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GQL mutation's exception handling logic #3431

Open
jopemachine opened this issue Jan 13, 2025 — with Lablup-Issue-Syncer · 0 comments
Open

Improve GQL mutation's exception handling logic #3431

jopemachine opened this issue Jan 13, 2025 — with Lablup-Issue-Syncer · 0 comments

Comments

@jopemachine
Copy link
Member

Motivation  

  • To enable more detailed error handling of GQL mutation failures on the frontend, the current method of relying on ok and msg needs to be improved.
  • Not only must the return type of all GQL mutations be modified, but the corresponding SDK, WebUI, and Control Panel logic that utilizes them also need to be updated.

Objective

  • Improve GQL mutation's common return type
  • Improve GQL Mutation exception handling Logic on the Client Side
  • The issue itself is relatively easy in complexity, but since this change introduces a big breaking change, care must be taken to avoid conflicts with the client side.

�Expected Sub Issue

  • Remove ok, msg from the current codebase’s GQL mutations.
  • Raise GraphQLError instead of using ok, msg.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant