-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom name for Field #223
Comments
@toptalo , I think my branch (and PR) https://github.com/labd/wagtailstreamforms/pull/160/files#diff-951d949d800424b6334469000bf4a47f1841b3fe5b59b25b81d07a779d9a3c11R65 might address your needs. I wonder if that's correct? |
@rgs258 |
Also, have a look into This method must use same logic of getting field name as in wagtailstreamforms/forms.py but for now it only use slug from label That is a point of my Issue - in different places field name makes in different ways |
Closes issue labd#223
Hello!
I have a custom submission hook that posts form data to external API.
This API has its own field names defined and I need possibility to control form fields names.
For that purpose I have added
neme
CharBlock toblocks.StructBlock
inget_form_block
method of BaseField inwagtailstreamforms_fields.py
I do that, because I found class method get_formfield_name() in source code that trys to get field name from block value
After that I have redefine form fields names, save form config and submit my form.
Than on submissions page I have see, that all new submissions displays with None value.
This was happend because in method get_data_fields field name is a slug generated from label, without checking
field["value"]["name"]
as was done inget_formfield_name
methodSo I have suggest to modify this method to respect field name value like so:
(field["value"]["name"] or get_slug_from_string(field["value"]["label"])
What dou you think?
I can make PR for that
The text was updated successfully, but these errors were encountered: