Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: excluded telemetry_int from of_multi_table subscribed napps #264

Closed
wants to merge 1 commit into from
Closed

chore: excluded telemetry_int from of_multi_table subscribed napps #264

wants to merge 1 commit into from

Conversation

viniarck
Copy link
Member

@viniarck viniarck commented Oct 12, 2023 •
edited
Loading

Closes #263

Summary

End-to-End Tests

Test suite test_e2e_60_of_multi_table is passing with this branch and PR kytos-ng/of_multi_table#21

$ ./kytos-init.sh
+ sed -i 's/STATS_INTERVAL = 60/STATS_INTERVAL = 7/g' /var/lib/kytos/napps/kytos/of_core/settings.py
+ sed -i 's/CONSISTENCY_MIN_VERDICT_INTERVAL =.*/CONSISTENCY_MIN_VERDICT_INTERVAL = 60/g' /var/lib/kytos/napps/kytos/flow_manager/settings.py
+ sed -i 's/LINK_UP_TIMER = 10/LINK_UP_TIMER = 1/g' /var/lib/kytos/napps/kytos/topology/settings.py
+ sed -i 's/DEPLOY_EVCS_INTERVAL = 60/DEPLOY_EVCS_INTERVAL = 5/g' /var/lib/kytos/napps/kytos/mef_eline/settings.py
+ sed -i 's/LLDP_LOOP_ACTIONS = \["log"\]/LLDP_LOOP_ACTIONS = \["disable","log"\]/' /var/lib/kytos/napps/kytos/of_lldp/settings.py
+ sed -i 's/LLDP_IGNORED_LOOPS = {}/LLDP_IGNORED_LOOPS = {"00:00:00:00:00:00:00:01": \[\[4, 5\]\]}/' /var/lib/kytos/napps/kytos/of_lldp/settings.py
+ sed -i 's/CONSISTENCY_COOKIE_IGNORED_RANGE =.*/CONSISTENCY_COOKIE_IGNORED_RANGE = [(0xdd00000000000000, 0xdd00000000000009)]/g' /var/lib/kytos/napps/kytos/flow_manager/settings.py
+ sed -i 's/LIVENESS_DEAD_MULTIPLIER =.*/LIVENESS_DEAD_MULTIPLIER = 3/g' /var/lib/kytos/napps/kytos/of_lldp/settings.py
+ sed -i 's/SUBSCRIBED_NAPPS =.*/SUBSCRIBED_NAPPS = {"coloring", "of_lldp", "mef_eline"}/g' /var/lib/kytos/napps/kytos/of_multi_table/settings.py
+ kytosd --help
+ sed -i s/WARNING/INFO/g /etc/kytos/logging.ini
+ test -z 'tests -k of_multi_table'
+ test -z ''
+ RERUNS=2
+ python3 scripts/wait_for_mongo.py
Trying to run hello command on MongoDB...
Trying to run 'hello' command on MongoDB...
Ran 'hello' command on MongoDB successfully. It's ready!
+ python3 -m pytest tests -k of_multi_table --reruns 2 -r fEr
============================= test session starts ==============================
platform linux -- Python 3.9.2, pytest-7.2.0, pluggy-1.3.0
rootdir: /builds/amlight/kytos-end-to-end-tester/kytos-end-to-end-tests
plugins: rerunfailures-10.2, timeout-2.1.0, anyio-3.6.2
collected 242 items / 237 deselected / 5 selected
tests/test_e2e_60_of_multi_table.py .....                                [100%]
========== 5 passed, 237 deselected, 35 warnings in 301.03s (0:05:01) ==========

@viniarck viniarck requested a review from a team as a code owner October 12, 2023 16:35
@viniarck viniarck marked this pull request as draft October 12, 2023 16:35
@viniarck viniarck requested a review from Alopalao October 12, 2023 17:03
@viniarck viniarck marked this pull request as ready for review October 12, 2023 17:03
Alopalao
Alopalao approved these changes Oct 13, 2023
View reviewed changes
Copy link

@Alopalao Alopalao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but it seems unnecessary. For a napp to be included in the required_napps set, it must be in the pipeline being enabled, inside SUBSCRIBED_NAPPS and installed. Currently, I have not found telemetry_int being installed in the dock image.

@viniarck
Copy link
Member Author

LGTM but it seems unnecessary. For a napp to be included in the required_napps set, it must be in the pipeline being enabled, inside SUBSCRIBED_NAPPS and installed. Currently, I have not found telemetry_int being installed in the dock image.

Indeed @Alopalao. Good point.

I was also hoping that it'd be one step towards also eventually supporting telemetry_int, when we also start using the noviflow backend, but then when we also were to build telemetry_int on the docker image other unit tests like test_e2e_01_kytos_startup.py would need to be augmented, and also of_multi_table settings.SUBSCRIBED_NAPPS would probably need to be set via an env var. So, I'll go ahead and close this PR and once we start supporting telemetry_int on e2e tests then issue #263 will get revisited. For completeness, I've also rerun e2e with the test suite test_e2e_60_of_multi_table without this branch here and it's passing as expected:

============================= test session starts ==============================
platform linux -- Python 3.9.2, pytest-7.2.0, pluggy-1.3.0
rootdir: /builds/amlight/kytos-end-to-end-tester/kytos-end-to-end-tests
plugins: rerunfailures-10.2, timeout-2.1.0, anyio-3.6.2
collected 242 items / 237 deselected / 5 selected
tests/test_e2e_60_of_multi_table.py .....                                [100%]
------------------------------- start/stop times -------------------------------
========== 5 passed, 237 deselected, 35 warnings in 290.48s (0:04:50) ==========

@viniarck viniarck closed this Oct 13, 2023
@viniarck viniarck mentioned this pull request Oct 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alopalao Alopalao Alopalao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exclude telemetry_int from of_multi_table settings.SUBSCRIBED_NAPPS
2 participants
@viniarck @Alopalao